transformnode: Avoid matrix multiplication if we can
authorTimm Bäder <mail@baedert.org>
Tue, 26 Feb 2019 06:24:18 +0000 (07:24 +0100)
committerTimm Bäder <mail@baedert.org>
Thu, 28 Feb 2019 06:22:34 +0000 (07:22 +0100)
If the given matrix is explicitly of category IDENTITY, we don't need to
do anything, and in the 2D_TRANSLATE case, just offset the child bounds.
Those are the two most common cases.

gsk/gskrendernodeimpl.c

index 1b7d5be39eaa8e08657ff97cce15dcabebac8320..114df174c2aa0c8bdf647d776b02f659a8a885bd 100644 (file)
@@ -2547,9 +2547,30 @@ gsk_transform_node_new_with_category (GskRenderNode           *child,
   graphene_matrix_init_from_matrix (&self->transform, transform);
   self->category = category;
 
-  graphene_matrix_transform_bounds (&self->transform,
-                                    &child->bounds,
-                                    &self->render_node.bounds);
+  switch (category)
+    {
+    case GSK_MATRIX_CATEGORY_IDENTITY:
+      graphene_rect_init_from_rect (&self->render_node.bounds, &child->bounds);
+    break;
+
+    case GSK_MATRIX_CATEGORY_2D_TRANSLATE:
+      {
+        graphene_rect_init_from_rect (&self->render_node.bounds, &child->bounds);
+        self->render_node.bounds.origin.x += graphene_matrix_get_value (transform, 3, 0);
+        self->render_node.bounds.origin.y += graphene_matrix_get_value (transform, 3, 1);
+      }
+    break;
+
+    case GSK_MATRIX_CATEGORY_2D_AFFINE:
+    case GSK_MATRIX_CATEGORY_ANY:
+    case GSK_MATRIX_CATEGORY_UNKNOWN:
+    case GSK_MATRIX_CATEGORY_INVERTIBLE:
+    default:
+      graphene_matrix_transform_bounds (&self->transform,
+                                        &child->bounds,
+                                        &self->render_node.bounds);
+    }
+
   return &self->render_node;
 }